Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consolidate backend secret custom resources into one #1998

Closed

Conversation

awsluja
Copy link
Contributor

@awsluja awsluja commented Sep 13, 2024

Problem

This consolidates secret fetcher custom resources into one.

A single custom resource will be created, instead of a resource for each secret.

Issue number, if available:
#1797
#1825

Changes

Corresponding docs PR, if applicable:

Validation

Tests updated.

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Sep 13, 2024

🦋 Changeset detected

Latest commit: ac67ec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

hoangnbn
hoangnbn previously approved these changes Sep 13, 2024
Copy link
Contributor

@hoangnbn hoangnbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great improvement!

@awsluja
Copy link
Contributor Author

awsluja commented Sep 17, 2024

closing in favor of #2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants