Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add log retention to defineFunction #2055

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lukebellamy053
Copy link

@lukebellamy053 lukebellamy053 commented Sep 25, 2024

Problem

Currently there is no way to set the log retention or log group of a function created using defineFunction. This is a fairly obvious issue as it means people will be paying for logs they may no longer want

Issue number, if available:

Changes

Added the option to specify a log retention period when using defineFunction

Corresponding docs PR, if applicable:

Validation

Added unit test that validate the cloud formation properties are correctly added

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lukebellamy053 lukebellamy053 requested review from a team as code owners September 25, 2024 23:02
Copy link

changeset-bot bot commented Sep 25, 2024

🦋 Changeset detected

Latest commit: e18e815

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/backend-function Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lukebellamy053 lukebellamy053 changed the title feat: add log group to defineFunction feat: add log retention to defineFunction Sep 26, 2024
@josefaidt josefaidt linked an issue Sep 26, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support configuring function log settings
1 participant