Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add e2e test for lambda data client #2228

Draft
wants to merge 11 commits into
base: stocaaro/client-schema/main
Choose a base branch
from

Conversation

stocaaro
Copy link
Member

Problem

The lambda data client needs to be covered by an e2e test.

Changes

  • Adds an e2e test for the lambda data client

Validation

Tested using
npm run test:dir packages/integration-tests/lib/test-e2e/sandbox/data_and_function_project.sandbox.test.js

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Nov 13, 2024

⚠️ No Changeset found

Latest commit: c934af2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

import { Amplify } from 'aws-amplify';
import { generateClient } from 'aws-amplify/data';
import type { Schema } from '../../data/resource.js';
// @ts-ignore
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esbuild during synth is fine with all of this, but the ts check before synth is unhappy. It looks like a workaround was used for data-storage-auth-with-triggers-ts of setting up fake files to make the pre-synth check happy. Should I replicate that here? It would avoid the exclude change in the tsconfig below too.

Seems fine, but also very fake since this file isn't being built in the project.

@stocaaro stocaaro changed the base branch from stocaaro/client-schema/main to main November 15, 2024 19:01
@stocaaro stocaaro changed the base branch from main to stocaaro/client-schema/main November 15, 2024 19:01
@stocaaro
Copy link
Member Author

This change has been merged into #2224

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant