Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wraps no outputs found error from backend output client #2368

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

Amplifiyer
Copy link
Contributor

Problem

If the first deployment (sandbox/branch) is unsuccessful, the stack ends up getting created but stays in CREATE_FAILED state and doesn't have any outputs or metadata associated with it. This passes the check/error NO_STACK_FOUND since there is indeed a stack, but no outputs.

Issue number, if available:

Changes

Add the new case of NO_OUTPUTS_FOUND and refactor bunch of if to a switch.

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented Dec 24, 2024

🦋 Changeset detected

Latest commit: f9dbcd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/model-generator Patch
@aws-amplify/client-config Patch
@aws-amplify/sandbox Patch
@aws-amplify/backend-cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Amplifiyer Amplifiyer marked this pull request as ready for review December 24, 2024 17:53
@Amplifiyer Amplifiyer requested review from a team as code owners December 24, 2024 17:53
@Amplifiyer Amplifiyer merged commit aaeda9b into main Dec 30, 2024
48 checks passed
@Amplifiyer Amplifiyer deleted the error_12 branch December 30, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants