Skip to content

Commit

Permalink
fix: make canary deps compatible with node 18 (#3098)
Browse files Browse the repository at this point in the history
---------

Co-authored-by: Phani Srikar Edupuganti <[email protected]>
  • Loading branch information
phani-srikar and Phani Srikar Edupuganti authored Jan 2, 2025
1 parent 0335da1 commit 383a0d9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
6 changes: 4 additions & 2 deletions client-test-apps/js/api-model-relationship-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,9 @@
"web-vitals": "^2.1.4"
},
"resolutions": {
"joi": "17.7.0"
"joi": "17.7.0",
"glob": "10.4.5",
"rimraf": "5.0.10"
},
"scripts": {
"start": "react-scripts start",
Expand Down Expand Up @@ -70,4 +72,4 @@
"axios": "axios/dist/node/axios.cjs"
}
}
}
}
2 changes: 2 additions & 0 deletions shared-scripts.sh
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,8 @@ function _runCanaryTest {
echo RUN Canary Test
loadCacheFromBuildJob
loadCache verdaccio-cache $CODEBUILD_SRC_DIR/../verdaccio-cache
# Set Node.js version to $AMPLIFY_NODE_VERSION as one of the package requires version ">= 18.18.0"
_setupNodeVersion $AMPLIFY_NODE_VERSION
_installCLIFromLocalRegistry
_loadTestAccountCredentials
_setShell
Expand Down

0 comments on commit 383a0d9

Please sign in to comment.