feat(api): enable cors on codegen asset bucket #2366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzhan-aws
reviewed
Mar 19, 2024
dzhan-aws
previously approved these changes
Mar 19, 2024
dpilch
previously approved these changes
Mar 19, 2024
phani-srikar
previously approved these changes
Mar 19, 2024
sundersc
dismissed stale reviews from phani-srikar, dpilch, and dzhan-aws
via
710d9aa
dpilch
previously approved these changes
Mar 20, 2024
phani-srikar
previously approved these changes
Mar 20, 2024
sundersc
changed the title
palpatim
previously approved these changes
Mar 25, 2024
|
Converting this to draft pending further review |
palpatim
changed the title
palpatim
approved these changes
Mar 26, 2024
dpilch
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Enable CORS on the codegen assets bucket. This is required for console team to access the objects from user context.
CDK / CloudFormation Parameters Changed
No.
Issue #, if available
NA.
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.