Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(generation-transformer): add generation transformer #2820
feat(generation-transformer): add generation transformer #2820
Changes from 20 commits
a3c265e
65bf4b8
df59807
26165a9
b73ae3e
4255f75
666dd56
8d1524a
b540c60
3e3b867
d4e5ab5
a8281de
c8052fd
296c497
ed314e9
9b7acb7
7839a2c
75a0972
118f4d2
8ab7bec
d85ea0c
27c2f37
51fe60a
61ff76a
54db06d
a3775a7
97018fa
0704d88
a941491
48ff9f0
0aaacc5
4de6c72
7919c94
3c4fc18
c0c662b
174470b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're asserting that we get an answer here, not the correct answer because LLMs are not good (being generous) at math.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is currently disabled because we throw in the transformer when the return type contains required fields typed as certain AppSync scalars.
We're exploring options, including prompt improvements, better regex pattern in JSON Schema tool definitions, and special case handling for models (omitting createdAt, updatedAt, and id in tool definition, and populating them in the resolver).
For now, this is an accepted current limitation.