chore: move json schema generation for tool use into transformer-core #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
commented
Sep 3, 2024
| @@ -55,7 +55,7 @@ | |||
| "coverageProvider": "v8", | |||
| "coverageThreshold": { | |||
| "global": { | |||
| "branches": 90, | |||
| "branches": 89, | |||
There was a problem hiding this comment.
Not sure why this was necessary. Will figure it out in a follow up -- for now it's still well above the 80% threshold.
sundersc
previously approved these changes
Sep 3, 2024
This was referenced Sep 3, 2024
|
|
palpatim
approved these changes
Sep 4, 2024
sundersc
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
No functional changes
amplify-graphql-transformer-coreso that they can be used by bothamplify-graphql-generation-transformerandamplify-graphql-conversation-transformer.CDK / CloudFormation Parameters Changed
N/A
Issue #, if available
N/A
Description of how you validated changes
Test suite passes
Checklist
yarn testpassesTests are changed or addedRelevant documentation is changed or added (and PR referenced)New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policiesAny CDK or CloudFormation parameter changes are called out explicitlyBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.