fix: fix policies with overridden table names #3075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atierian
previously approved these changes
Dec 16, 2024
packages/amplify-graphql-model-transformer/src/resources/dynamo-model-resource-generator.ts
Outdated
Show resolved
Hide resolved
atierian
approved these changes
Dec 17, 2024
atierian
approved these changes
Dec 17, 2024
tejas2008
approved these changes
Dec 17, 2024
palpatim
deleted the
palpatim.fix.policies-with-overridden-table-name
branch
2 tasks
awsluja
reviewed
Dec 20, 2024
|
|
||
| while (isTruncated) { | ||
| const params = marker ? { Marker: marker } : {}; | ||
| const response = await service.listRoles(params).promise(); |
There was a problem hiding this comment.
Late response to this comment: the listRoles response is paginated, using Marker as the "next token" equivalent. See https://docs.aws.amazon.com/AWSJavaScriptSDK/v3/latest/client/iam/command/ListRolesCommand/
Siqi-Shan
added a commit
that referenced
this pull request
Dec 20, 2024
This reverts commit fdcb760.
Siqi-Shan
added a commit
that referenced
this pull request
Dec 20, 2024
palpatim
added a commit
that referenced
this pull request
Jan 8, 2025
palpatim
added a commit
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes policy resources generated for tables with overridden names. The change is simple: it removes the
withoutPolicyUpdates()modifier from the role returned during DDB resolver resource creation. This allows Amplify's call to the AppSync CDK APIaddDynamoDbDataSourceto set up a default policy. That grant API uses the table construct to determine the name, rather than relying on the Amplify naming convention. The default policy is therefore scoped to table & index resources with the appropriate name.Issue #, if available
#3006
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.