Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add skeloton validate transformer package and @validate directive definition #3121

Merged
merged 17 commits into from
Jan 21, 2025

Conversation

bobbyu99
Copy link
Contributor

@bobbyu99 bobbyu99 commented Jan 17, 2025

Description of changes

This PR added a new @validate directive and a graphql-validate-transformer package.

Detail of changes:

  • set up a new graphql-validate-transformer package with some package configurations
    • added ValidateTransformer class that does nothing for now
    • added 1 test file that does nothing for now
  • updated a bunch of package.json with the new graphql-validate-transformer package
  • updated snapshot test and transformer test to acknowledge the new transformer
  • added ValidateTransformer to transformer chain
  • added validate slot
  • added @validate directive definitions (API approved)

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • E2E test run linked
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)
  • New AWS SDK calls or CloudFormation actions have been added to relevant test and service IAM policies
  • Any CDK or CloudFormation parameter changes are called out explicitly

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bobbyu99 bobbyu99 marked this pull request as ready for review January 21, 2025 16:56
@bobbyu99 bobbyu99 requested review from a team as code owners January 21, 2025 16:56
@bobbyu99 bobbyu99 enabled auto-merge (squash) January 21, 2025 16:57
}

generateResolvers = (ctx: TransformerContextProvider): void => {
console.log('generateResolvers', ctx);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Consider adding TODO comment to the sections which will require changes in the upcoming PRs.

@bobbyu99 bobbyu99 merged commit bc6e88b into feature/server-side-validation Jan 21, 2025
7 checks passed
@bobbyu99 bobbyu99 deleted the validate-transformer-package branch January 21, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants