feat: rename iam -> identityPool in data-schema #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d193c86 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
svidgen
approved these changes
Apr 26, 2024
HuiSF
approved these changes
Apr 26, 2024
| @@ -571,7 +571,9 @@ function calculateAuth(authorization: Authorization<any, any, any>[]) { | |||
| } | |||
|
|
|||
| if (rule.provider) { | |||
| ruleParts.push(`provider: ${rule.provider}`); | |||
| // identityPool maps to iam in the transform | |||
| const provider = rule.provider === 'identityPool' ? 'iam' : rule.provider; | |||
There was a problem hiding this comment.
For my own curiosity will the Amplify schema to be updated eventually to use the consistent identityPool string?
There was a problem hiding this comment.
I'm not sure to be honest. Maybe not, since it's still IAM as far as AppSync is concerned. We're just trying to make it a bit less confusing for gen2 customers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
iam->identityPoolin schema builderidentityPool(iamremains valid on the client)Related JS PR: aws-amplify/amplify-js#13299
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.