apply suggestions

aws-amplify · Mar 18, 2024 · 45c0c34 · 45c0c34
1 parent 4839fb8
commit 45c0c34
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 16 deletions.
diff --git a/packages/core/__tests__/BackgroundProcessManager.test.ts b/packages/core/__tests__/BackgroundProcessManager.test.ts
@@ -428,7 +428,7 @@ describe('BackgroundProcessManager', () => {
 		const manager = new BackgroundProcessManager();
 		let count = 0;
 
-		const _ = new Observable(observer => {
+		new Observable(observer => {
 			const interval = setInterval(() => {
 				observer.next({});
 			}, 10);

diff --git a/packages/core/__tests__/ConsoleLogger.test.ts b/packages/core/__tests__/ConsoleLogger.test.ts
@@ -1,15 +1,18 @@
 import { ConsoleLogger } from '../src';
-import { LoggingProvider, LogType } from '../src/Logger/types';
+import { LogType, LoggingProvider } from '../src/Logger/types';
 
 type LogEvent = 'verbose' | 'debug' | 'info' | 'warn' | 'error';
 
 describe('ConsoleLogger', () => {
+	const noop = () => {
+		// no op
+	};
 	beforeAll(() => {
-		jest.spyOn(console, 'log').mockImplementation(() => {});
-		jest.spyOn(console, 'error').mockImplementation(() => {});
-		jest.spyOn(console, 'warn').mockImplementation(() => {});
-		jest.spyOn(console, 'info').mockImplementation(() => {});
-		jest.spyOn(console, 'debug').mockImplementation(() => {});
+		jest.spyOn(console, 'log').mockImplementation(noop);
+		jest.spyOn(console, 'error').mockImplementation(noop);
+		jest.spyOn(console, 'warn').mockImplementation(noop);
+		jest.spyOn(console, 'info').mockImplementation(noop);
+		jest.spyOn(console, 'debug').mockImplementation(noop);
 	});
 	afterEach(() => {
 		jest.clearAllMocks();

diff --git a/packages/core/__tests__/clients/composeApiHandler.test.ts b/packages/core/__tests__/clients/composeApiHandler.test.ts
@@ -22,8 +22,8 @@ describe(composeServiceApi.name, () => {
 		const mockTransferHandler = jest.fn().mockResolvedValue(defaultResponse);
 		const api = composeServiceApi(
 			mockTransferHandler,
-			_ => defaultRequest,
-			async _ => ({
+			() => defaultRequest,
+			async () => ({
 				Result: 'from API',
 			}),
 			defaultConfig,
@@ -47,8 +47,8 @@ describe(composeServiceApi.name, () => {
 		};
 		const api = composeServiceApi(
 			mockTransferHandler,
-			__ => defaultRequest,
-			async __ => ({
+			() => defaultRequest,
+			async () => ({
 				Result: 'from API',
 			}),
 			defaultConfig,

diff --git a/packages/core/__tests__/utils/queuedStorage/queuedStorage.native.test.ts b/packages/core/__tests__/utils/queuedStorage/queuedStorage.native.test.ts
@@ -131,18 +131,13 @@ describe('createQueuedStorage', () => {
 
 	describe('method add()', () => {
 		let queuedStorage: QueuedStorage;
-		// let originalDate;
 		let dateNowSpy: jest.SpyInstance;
 		const testInput: ItemToAdd = {
 			content: 'some log content',
 			timestamp: mockTimestamp,
 		};
 
 		beforeAll(() => {
-			// originalDate = Date;
-			// Date = {
-			// 	now: jest.fn(() => 123),
-			// } as any;
 			dateNowSpy = jest.spyOn(Date, 'now').mockReturnValue(123);
 			queuedStorage = createQueuedStorage();
 		});