fix: Support tracking multiple inflight OAuth promise resolvers (#12482)

aws-amplify · Oct 31, 2023 · ad5c83e · ad5c83e
1 parent 091f681
commit ad5c83e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/packages/auth/package.json b/packages/auth/package.json
@@ -7,8 +7,8 @@
 	"typings": "./lib-esm/index.d.ts",
 	"react-native": "./lib-esm/index.js",
 	"sideEffects": [
-		"./lib/providers/cognito/apis/signInWithOAuth.js",
-		"./lib-esm/providers/cognito/apis/signInWithOAuth.js"
+		"./lib/providers/cognito/apis/signInWithRedirect.js",
+		"./lib-esm/providers/cognito/apis/signInWithRedirect.js"
 	],
 	"publishConfig": {
 		"access": "public"

diff --git a/packages/auth/src/providers/cognito/apis/signInWithRedirect.ts b/packages/auth/src/providers/cognito/apis/signInWithRedirect.ts
@@ -461,11 +461,14 @@ function urlListener() {
 isBrowser() && urlListener();
 
 // This has a reference for listeners that requires to be notified, TokenOrchestrator use this for load tokens
-let resolveInflightPromise = () => {};
+let inflightPromiseResolvers: ((value: void | PromiseLike<void>) => void)[] =
+	[];
 
 const invokeAndClearPromise = () => {
-	resolveInflightPromise();
-	resolveInflightPromise = () => {};
+	for (const promiseResolver of inflightPromiseResolvers) {
+		promiseResolver();
+	}
+	inflightPromiseResolvers = [];
 };
 
 isBrowser() &&
@@ -475,7 +478,7 @@ isBrowser() &&
 				if (!(await store.loadOAuthInFlight())) {
 					res();
 				} else {
-					resolveInflightPromise = res;
+					inflightPromiseResolvers.push(res);
 				}
 				return;
 			})

diff --git a/packages/aws-amplify/package.json b/packages/aws-amplify/package.json
@@ -340,7 +340,7 @@
 			"name": "[Auth] confirmSignIn (Cognito)",
 			"path": "./lib-esm/auth/index.js",
 			"import": "{ confirmSignIn }",
-			"limit": "25.48 kB"
+			"limit": "25.55 kB"
 		},
 		{
 			"name": "[Auth] updateMFAPreference (Cognito)",
@@ -412,7 +412,7 @@
 			"name": "[Auth] OAuth Auth Flow (Cognito)",
 			"path": "./lib-esm/auth/index.js",
 			"import": "{ signInWithRedirect, signOut, fetchAuthSession }",
-			"limit": "19.53 kB"
+			"limit": "19.61 kB"
 		},
 		{
 			"name": "[Storage] copy (S3)",