fix(auth): add signInDetails on refreshTokens action

aws-amplify · Mar 20, 2024 · eb1f5c6 · eb1f5c6
1 parent bd1fefd
commit eb1f5c6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/packages/auth/__tests__/providers/cognito/tokenProvider/tokenOrchestrator.test.ts b/packages/auth/__tests__/providers/cognito/tokenProvider/tokenOrchestrator.test.ts
@@ -14,8 +14,6 @@ jest.mock('@aws-amplify/core', () => ({
 	},
 }));
 
-const mockAssertTokenProviderConfig = assertTokenProviderConfig as jest.Mock;
-
 describe('tokenOrchestrator', () => {
 	const mockTokenRefresher = jest.fn();
 	const mockTokenStore = {
@@ -36,14 +34,19 @@ describe('tokenOrchestrator', () => {
 	describe('refreshTokens method', () => {
 		it('calls the set tokenRefresher, tokenStore and Hub while refreshing tokens', async () => {
 			const testUsername = 'username';
+			const testSignInDetails= {
+				authFlowType:'CUSTOM_WITHOUT_SRP',
+				loginId: testUsername
+			} as const;
 			const testInputTokens = {
 				accessToken: {
 					payload: {},
 				},
 				clockDrift: 400000,
 				username: testUsername,
+				signInDetails:testSignInDetails
 			};
-
+			// mock tokens should not include signInDetails
 			const mockTokens: CognitoAuthTokens = {
 				accessToken: {
 					payload: {},
@@ -58,6 +61,7 @@ describe('tokenOrchestrator', () => {
 				username: testUsername,
 			});
 
+			console.log(newTokens);
 			// ensure the underlying async operations to be completed
 			// async #1
 			expect(mockTokenRefresher).toHaveBeenCalledWith(
@@ -71,6 +75,7 @@ describe('tokenOrchestrator', () => {
 
 			// ensure the result is correct
 			expect(newTokens).toEqual(mockTokens);
+			expect(newTokens?.signInDetails).toEqual(testSignInDetails)
 		});
 	});
 });
diff --git a/packages/auth/src/providers/cognito/tokenProvider/TokenOrchestrator.ts b/packages/auth/src/providers/cognito/tokenProvider/TokenOrchestrator.ts
@@ -127,12 +127,13 @@ export class TokenOrchestrator implements AuthTokenOrchestrator {
 		username: string;
 	}): Promise<CognitoAuthTokens | null> {
 		try {
+			const signInDetails = tokens.signInDetails;
 			const newTokens = await this.getTokenRefresher()({
 				tokens,
 				authConfig: this.authConfig,
 				username,
 			});
-
+			newTokens.signInDetails = signInDetails;
 			await this.setTokens({ tokens: newTokens });
 			Hub.dispatch('auth', { event: 'tokenRefresh' }, 'Auth', AMPLIFY_SYMBOL);