-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add canary tests #11721
chore: add canary tests #11721
Conversation
Is |
It's similar but with the removal of several integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if some of this can be separate
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #11721 +/- ##
=======================================
Coverage 83.71% 83.71%
=======================================
Files 347 347
Lines 21684 21684
Branches 4613 4613
=======================================
Hits 18152 18152
Misses 3245 3245
Partials 287 287 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks @yingku 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @yingku
* feat(data): add CCI config for GraphQL API optimistic UI E2E tests (#11585) * chore: update size limit that is too tight (#11652) * chore: update size limit that is too tight * chore(prediction): update size limit after custom s3 client * fix: duplicate entry in connection states (#11579) Co-authored-by: Aaron S <[email protected]> Co-authored-by: AllanZhengYP <[email protected]> * fix(api-rest): refactor ajax method to not relying on side effects (#11498) * fix(api-rest): refactor ajax method to not relying on side effects the previous Signer.sign() implementation not only returns signed request, but also sets the signed headers to input request. The recent refactor makes it side-effect-less. However this change breaks RestClient.ajax() clock skew correction which relies on the x-amz-date header set by signer to the input request object to indicate the current client side time. this fix resolves #11480 * chore: Enable automatic license checking (#11604) * chore(release): Publish [ci skip] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] * chore(release): update API docs [ci skip] * chore: Move Storage TS dependency to `devDependencies` (#11666) * chore: pin @smtihy/types to 1.1.0 to prevent build failure in TS3.8 (#11673) chore: ping @smtihy/types to 1.1.0 to prevent build failure in TS3.8 This is ok because the AWS SDK and crypto dependencies have been pinned already * chore: remove smithy resolution (#11682) * feat: custom user agent Geo changes for UI handoff (#11632) * feat: custom user agent Storage changes for UI handoff (#11627) * chore: move storage code to InternalStorage.ts * chore: update class and module name to InternalStorage and update imports * feat: add customUserAgentDetails param to public methods * feat: add customUserAgentDetails to getProperties methods, fix cancel overload * feat: make Storage extend internal storage and override public methods * feat: export InternalStorage from internals scope * feat: send user agent details from public copy api to service call * fix: add missing storage action, fix other minor issues * feat: add userAgentValue with received user agent details to AWSS3Provider options * fix: send getproperties instead of copy from getproperties method * test: update tests to handle new form of passing user agent * Revert "test: update tests to handle new form of passing user agent" This reverts commit 4bc7c48. * fix: fix jumbled StorageActions * test: update CustomUserAgent test * test: remove storageAction param and asserts from test * chore: increase bundle size limits * chore: publish feature branch for testing * Feat/custom user agent UI/inappmessaging (#11656) * chore: copy InAppMessaging to InternalInAppMessaging * feat: add customUserAgentDetails param to InternalInAppMessaging * feat: make InAppMessaging extend InternalInAppMessaging * feat: send sync userAgentDetails through to service call * fix: add SyncMessages value to InAppMessagingAction * chore: remove extra parameter from non-service-call functions * fix: fix typo in InAppMessagingAction * feat: send user agent details through identify user to service call * chore: remove unused import * feat: allow InAppMessaging to be configured independently of Notifications * test: update tests for internal changes * build: export InternalInAppMessaging from scoped path * fix: resolve bundle size * chore: bundle size settings * chore: increase bundle size limits * chore: fix typo * fix: update references to type with typo * Feat/custom user agent UI/geo (#11657) * chore: copy Geo code into InternalGeo * feat: add geo actions * feat: add customUserAgentDetails to geo provider * feat: add customUserAgentDetails to public api's and send to service calls * feat: make Geo extend InternalGeo and override public API's * build: export InternalGeo from scoped geo/internals path * chore: increase bundle size limits * chore: increase bundle size limits * feat: add user agent param to action that was missed * chore: update doc-strings with new param * Revert "Merge branch 'feat/custom-user-agent-ui/main' into feat/custom-user-agent-ui/storage" This reverts commit f0e8657, reversing changes made to ec1ed1a. * fix: remove userAgentValue from CommonStorageOptions * feat: add userAgentValue param to StorageProvider and implement * fix: update config type to param type at position * test: update test class based on changes * chore: add new param to jsdocs * chore: update comment from LastParameter (now ConfigParameter) * chore: add comment explaining StorageProviderApiOptionsIndexMap * chore: increase bundle size limits * fix: send userAgentValue through storage put and list * chore: remove outdated TODO comment * chore: increase bundle size limits * feat: custom user agent InAppMessaging changes for UI handoff (#11639) * chore: copy InAppMessaging to InternalInAppMessaging * feat: add customUserAgentDetails param to InternalInAppMessaging * feat: make InAppMessaging extend InternalInAppMessaging * feat: send sync userAgentDetails through to service call * fix: add SyncMessages value to InAppMessagingAction * chore: remove extra parameter from non-service-call functions * fix: fix typo in InAppMessagingAction * feat: send user agent details through identify user to service call * chore: remove unused import * feat: allow InAppMessaging to be configured independently of Notifications * test: update tests for internal changes * build: export InternalInAppMessaging from scoped path * fix: resolve bundle size * chore: bundle size settings * chore: increase bundle size limits * chore: fix typo * fix: update references to type with typo * chore: update jsdocs in InternalInAppMessaging * chore: increase bundle size limit * chore: shorten jsdocs comment * fix: first attempt to fix InAppMessaging internals * fix: fix internals package.json paths * test: fix import form internals * chore: increase bundle size limits * chore(release): Publish [ci skip] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - [email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] - @aws-amplify/[email protected] * chore(release): update API docs [ci skip] * chore: Migrate CI/CD to GitHub Actions (#11638) * feat: Actions for pr testing (#12) * feat: Add working e2e example (#14) * chore: Add configurable e2e tests to GH workflows (#15) * feat(e2e): add integ test runner and test * fix(e2e): retain existing workflows * fix(e2e): remove old e2e example --------- Co-authored-by: Sridhar <[email protected]> * chore: add e2e browser auth tests (#16) * chore: add e2e browser auth tests * chore: code cleanup --------- Co-authored-by: Sridhar <[email protected]> * chore: add e2e browser predictions interactions tests (#17) * chore: add e2e integ_react_predictions * chore: add browser e2e interactions --------- Co-authored-by: Sridhar <[email protected]> Co-authored-by: Aaron S <[email protected]> * chore: limit PR concurrency (#19) * chore: add build_type and enable retry (#18) * prod & dev * -n 3 * turn off fail-fast --------- Co-authored-by: Aaron S <[email protected]> * chore: add e2e browser datastore tests (#20) Co-authored-by: Sridhar <[email protected]> * chore: add e2e browser api,storage tests (#21) Co-authored-by: Sridhar <[email protected]> * chore: fix single browser provided in integ-config (#22) Co-authored-by: Sridhar <[email protected]> * chore: Run dev and prod on the same runner * chore: Add detox testing (#26) * Feat/GitHub actions/test ashwinkumar6 (#27) * chore: Re-arrange integ test configurations and improve prebuild (#29) * chore: Re-arrange integ test configurations and inprove preflight * Fix is-preflight flag * Change preflight to prebuild for consistencu * Disable fast fail on unit tests * feat: Change yaml load output pattern * chore: fix e2e integ_datastore_auth_v2 test * chore: disable playwright tests (#33) Co-authored-by: Sridhar <[email protected]> * chore: add google env variables for e2e datastore tests (#35) Co-authored-by: Sridhar <[email protected]> * chore: add support for uploading artifacts (#34) * chore: test upload artifacts * chore: test uploading artifact * chore: Detox fix and step cleanup * chore: Increase detox time limit * chore: Turn warn to ignore for upload artifact misses * chore: Disable broken detox tests * chore: Disable PN testing and remove datastore test not running in circle * chore: e2e add configurable time_out and retry_count (#36) Co-authored-by: Sridhar <[email protected]> * chore: Increase deviceTracking timeout * chore: add deploy workflow (#37) * chore: add deploy workflow * chore: gh actions publish code clean up --------- Co-authored-by: Sridhar <[email protected]> * chore: Model full CI/CD flow - improve preid release (#38) * fix: Cache on the single yarn.lock instead of all * fix: Sync with main * chore: Revert to relative path use (#40) * chore: Revert to relative path use * fix: Remove path from workflows * chore: Add post-release merge to main * chore: Remove orphaned workflow files * chore: e2e add integ_auth_test_cypress_no_ui test (#39) * chore: e2e add integ_auth_test_cypress_no_ui test * chore: code cleanup --------- Co-authored-by: Sridhar <[email protected]> * chore: change github name and email * chore: update yarn.log * chore: move additional e2e commented tests (#43) * chore: move additional e2e commented tests * chore: add required permissions to script file --------- Co-authored-by: Sridhar <[email protected]> * chore: e2e keep test_name same as CCI (#45) * chore: e2e keep test_name same as CCI * chore: e2e re-arrange integ config --------- Co-authored-by: Sridhar <[email protected]> * chore: update actions typo Co-authored-by: William Lee <[email protected]> * chore: update actions typo Co-authored-by: William Lee <[email protected]> * chore: cleanup github_email and github_name (#46) Co-authored-by: Sridhar <[email protected]> * chore: cleanup load verdaccio action (#47) Co-authored-by: Sridhar <[email protected]> * chore: actions code cleanup (#48) Co-authored-by: Sridhar <[email protected]> * chore: Remove unused actions and use env vars instead of injection in run commands (#49) * chore: add retention period and timeout for cache (#50) * chore: add retention period and timeout for cache * chore: code cleanup --------- Co-authored-by: Sridhar <[email protected]> * chore: Chanke js token name * chore: Filter preid content * chore: Move file names around and consume env vars * fix: Rest bundle size increase * chore: Compactify on syntax * chore: dynamically fetch the repo_owner_name (#52) * chore: dynamically fetch the repo_owner_name * chore: code cleanup --------- Co-authored-by: Sridhar <[email protected]> * chore: Configure staging to use corresponding branch name * chore: Naming and cleanup * chore: Naming and dependency workflow improvements * chore: Fix vars use for gh user/email * chore: run e2e Rollup + DataStore test on just chrome (#54) Co-authored-by: Sridhar <[email protected]> * chore: Add preid protection (#57) * chore: Only publish to npm from the aws-amplify org * chore: add concurrency to push workflows (#56) * chore: add concurrency to push workflows * chore: code cleanup --------- Co-authored-by: Sridhar <[email protected]> * chore: Prepare for merge to main * chore: Fix circle build * chore: Okay, this will fix circle! * chore: Integrate license checking into pr check * chore: Add github action static tests * chore: Fix test command * Update .github/actions/npm-publish/action.yml Co-authored-by: Jim Blanchard <[email protected]> * chore: Fix names and descriptions --------- Co-authored-by: Ashwin Kumar <[email protected]> Co-authored-by: Sridhar <[email protected]> Co-authored-by: Lucas Yingshyan Ku <[email protected]> Co-authored-by: William Lee <[email protected]> Co-authored-by: Jim Blanchard <[email protected]> * chore: Migrate from circle to github actions (#11714) * chore: Disable RSC test for firefox (#11719) * chore: Reintroduce circle without deploy/post-release steps (#11720) * chore: Reintroduce circle without deploy/post-release steps * chore: Fix yarn.lock issue * chore: Update yarn.lock (#11725) * chore: add canary tests (#11721) * chore: add canary testing --------- Co-authored-by: Aaron S <[email protected]> Co-authored-by: Francisco Rodriguez <[email protected]> * fix: update on-schedule-canary-test.yml (#11733) Update on-schedule-canary-test.yml * chore: Remove jsdoc (#11731) * chore: remove unused cypress (#11732) * chore: update react-native version (#11734) Co-authored-by: Sridhar <[email protected]> * feat: custom user agent InternalCognitoUser (#11709) * chore: port code from CognitoUser and CognitoUserPool to internals * chore: delete InternalCognitoUserPool - separate PR * chore: update imports and class name * feat: add userAgentValue param to cognito client api's * feat: add userAgentValue param to InternalCognitoUser api's, pass to client * feat: make CognitoUser extend InternalCognitoUser and override api's * test: update tests to work with additional param, minor fix * chore: clean up unused imports and const's * feat: add missing userAgentValue param * chore: add new param to documentation comments * build: export InternalCognitoUser from internals scope * fix: remove default from InternalCognitoUser to fix scoped export * fix: fix typo causing signOut failure * build: correct index.d.ts files with changes * test: revert auth tests * chore: increase bundle size limits * chore: simplify InternalCognitoUser import --------- Co-authored-by: israx <[email protected]> * chore: run canary everyday at 9am (#11735) * chore: run canary everyday at 9am * chore: code cleanup Co-authored-by: Venkata Ramyasri Kota <[email protected]> * chore: update canary cron to 9amPDT * chore: code cleanup --------- Co-authored-by: Sridhar <[email protected]> Co-authored-by: Venkata Ramyasri Kota <[email protected]> * feat: custom user agent Auth changes for UI handoff (#11606) * chore: copy Auth code to InternalAuth * feat: add customUserAgentDetails param to InternalAuth methods * feat: make AuthClass extend InternalAuthClass, override functions with extra param * build: export auth internals from /internals scope * fix: changes signUp back to method type instead of prop so Auth can extend the method * chore: update auth lint settings to allow class arrow functions to end in semi-colon * fix: add overloaded method signature back in - unrelated change * test: fix auth tests by mocking InternalAuthClass instead of AuthClass * chore: change arrow methods to normal functions * fix: remove async from overridden async functions * chore: increase bundle size limits * fix: remove internalSignUp and fix rest attr with overload and any * fix: remove internalSignUp and fix rest attr with overload and any * chore: update jsdocs * chore: increase bundle size limits * chore: Added retries to unstable DataStore canaries (#11740) * fix(notifications): ios module pod cannot be autolinked in RN version < 0.69 (#11751) * chore: Remove eslint from `amazon-cognito-identity-js` (#11749) * feat: custom user agent InternalCognitoUserPool (#11716) * chore: port CognitoUserPool over to InternalCognitoUserPool * chore: restore CognitoUserPool * feat: add userAgentValue parameter to signUp * feat: update class name and imports * feat: make CognitoUserPool extend internal and override signUp * feat: export InternalCognitoUserPool from internals index * feat: send userAgentValue to client service call * test: fix internalsIndex test * build: export InternalCognitoUserPool from internals scope * chore: update CognitoUserPool type to extend internal * Apply suggestions from code review Co-authored-by: Jim Blanchard <[email protected]> * chore: remove unnecessary test on internals index * chore: increase bundle size limit --------- Co-authored-by: Jim Blanchard <[email protected]> Co-authored-by: israx <[email protected]> * chore: Bump DataStore join unit test time limit (#11753) * chore: Upgrade amazon-cognito-identity-json Webpack & other changes (#11746) * fix: Remove cpx dependency from pubsub (#11752) * chore: update increase run count for unstable integ tests (#11758) Co-authored-by: Sridhar <[email protected]> * chore: bump commonmarker from 0.23.9 to 0.23.10 in /docs (#11754) Bumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.9 to 0.23.10. - [Release notes](https://github.com/gjtorikian/commonmarker/releases) - [Changelog](https://github.com/gjtorikian/commonmarker/blob/v0.23.10/CHANGELOG.md) - [Commits](gjtorikian/commonmarker@v0.23.9...v0.23.10) --- updated-dependencies: - dependency-name: commonmarker dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jim Blanchard <[email protected]> * chore: Update `amazon-cognito-identity-js` to use Webpack 5 (#11757) * fixed build issues; revert api-graphql package merge changes * fixed bundle size limits, added empty test command to types package to keep lerna happy * bundle size limits * updated preid for api-v6 * fixed branch name for tagged release trigger --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: David McAfee <[email protected]> Co-authored-by: AllanZhengYP <[email protected]> Co-authored-by: takpen <[email protected]> Co-authored-by: Aaron S <[email protected]> Co-authored-by: Jim Blanchard <[email protected]> Co-authored-by: aws-amplify-bot <[email protected]> Co-authored-by: israx <[email protected]> Co-authored-by: erinleigh90 <[email protected]> Co-authored-by: Ashwin Kumar <[email protected]> Co-authored-by: Sridhar <[email protected]> Co-authored-by: Lucas Yingshyan Ku <[email protected]> Co-authored-by: William Lee <[email protected]> Co-authored-by: Francisco Rodriguez <[email protected]> Co-authored-by: Hui Zhao <[email protected]> Co-authored-by: Venkata Ramyasri Kota <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Description of changes
Addition of automated canary tests which run on intervals of 60m as well as on post-release.
Description of how you validated changes
By executing workflow runs through GitHub Actions to ensure everything is running smoothly.
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.