chore(api): hide generateClient from api/server subpath #12483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iartemiev
reviewed
Oct 31, 2023
| @@ -1,7 +1,7 @@ | |||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
|
|
|||
| import { generateClient as internalGenerateClient } from '@aws-amplify/api/server'; | |||
| import { generateClient as internalGenerateClient } from '@aws-amplify/api/internals'; | |||
There was a problem hiding this comment.
There are 2 versions of generateClient. We want the server one here
There was a problem hiding this comment.
I moved the server edition of generateClient into packages/api/src/internals/InternalAPI.ts which is being exported from '@aws-amplify/api/internals' in this PR.
Should rename the function to make it clearer it's the server edition?
jimblanc
previously approved these changes
Oct 31, 2023
AllanZhengYP
previously approved these changes
Oct 31, 2023
HuiSF
force-pushed
the
hui/chore/fix-api-exports
branch
from
d0638a3 to
270f486
Compare
jimblanc
approved these changes
Oct 31, 2023
iartemiev
approved these changes
Oct 31, 2023
AllanZhengYP
approved these changes
Oct 31, 2023
HuiSF
force-pushed
the
hui/chore/fix-api-exports
branch
from
270f486 to
1248617
Compare
iartemiev
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
apiinadapter-nextjspackages.jsonfilesgenerateClientfromaws-amplify/api/serverIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.