chore: add missing auto sign-in unit tests #12484
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israx
changed the title
erinleigh90
suggested changes
Nov 1, 2023
| autoSignIn, | ||
| resetAutoSignIn, | ||
| } from '../../../src/providers/cognito/apis/autoSignIn'; | ||
| import * as clients from '../../../src/providers/cognito/utils/clients/CognitoIdentityProvider'; |
There was a problem hiding this comment.
Super nit: this is importing a single (CognitoIdentityProvider) client, so the plural name could be misleading.
| }); | ||
|
|
||
| test('Auto sign-in should resolve to a signIn output', async () => { | ||
| const signInOutput = await autoSignIn(); | ||
| expect(signInOutput).toEqual(authAPITestParams.signInResult()); | ||
| expect(handleUserSRPAuthflowSpy).toBeCalledTimes(1); | ||
| }); | ||
|
|
||
| test('Auto sign-in should not resolve if a different user is confirmed', async () => { |
There was a problem hiding this comment.
I don't know if this is what is being tested here. It looks like we never test auto sign-in after the first user is confirmed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
add the following tests cases for auto sign-in:
confirmSignUpfailssignUpshould return "COMPLETE_AUTO_SIGN_IN" step whenautoSignInis enabled with verification link.Issue #, if available
Description of how you validated changes
yarn test
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.