Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): unit validating clockskew offset is updated when client clock back and forth #12495

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

AllanZhengYP
Copy link
Member

@AllanZhengYP AllanZhengYP commented Nov 2, 2023

Description of changes

Add extra unit test to make validate the error mentioned in #12450 (comment) is handled in v6

Issue #, if available

Tandem with #12488

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@AllanZhengYP AllanZhengYP marked this pull request as ready for review November 2, 2023 18:01
@AllanZhengYP AllanZhengYP requested review from a team as code owners November 2, 2023 18:01
Copy link
Contributor

@david-mcafee david-mcafee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting this over to V6! LGTM!

@AllanZhengYP AllanZhengYP merged commit 1aa0c2b into aws-amplify:main Nov 2, 2023
27 of 28 checks passed
AllanZhengYP added a commit to AllanZhengYP/amplify-js that referenced this pull request Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants