fix(analytics): add options for configuring pinpoint event buffer #12521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d
force-pushed
the
5d/pinpoint-buffer-options
branch
from
d2b1d90 to
c1d8737
Compare
elorzafe
reviewed
Nov 7, 2023
Comment on lines
+28
to
+31
| bufferSize, | ||
| flushInterval, | ||
| flushSize, | ||
| resendLimit, |
There was a problem hiding this comment.
what happens with the default values?
There was a problem hiding this comment.
As some of the API implementations relies on the value of these options (e.g. resentLimit in record API), they've been already resolved before getEventBuffer. The options in getEventBuffer function are non-optional.
Merged
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
EventBufferConfigoptions toPinpointProviderConfigIssue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.