Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth|aws-amplify): fix instance naming (use camel-case) #12533

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Nov 8, 2023

Description of changes

Use camel-case naming for the cognitoUserPoolsTokenProvider instance.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner November 8, 2023 23:18
Copy link
Contributor

@abdallahshaban557 abdallahshaban557 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HuiSF HuiSF force-pushed the hui/chore/auth/correct-naming branch from 9416f98 to 2431278 Compare November 8, 2023 23:26
Copy link
Contributor

@elorzafe elorzafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Thanks @HuiSF 🏅

@HuiSF HuiSF merged commit bd73367 into main Nov 8, 2023
29 checks passed
@HuiSF HuiSF deleted the hui/chore/auth/correct-naming branch November 8, 2023 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants