chore: Upgrade Lerna & remove Husky hook #12599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
commented
Nov 20, 2023
There was a problem hiding this comment.
Had to remove this as per the Lerna v7 release notes: https://github.com/lerna/lerna/blob/main/CHANGELOG.md#700-2023-06-08
Lerna will now use package manager settings.
jimblanc
commented
Nov 20, 2023
| @@ -92,18 +87,17 @@ | |||
| "@types/lodash": "4.14.182", | |||
| "@types/node": "^8.9.5", | |||
| "@types/puppeteer": "1.3.0", | |||
| "@lerna/legacy-package-management": "^7.4.2", | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This change upgrades Lerna to v7 to unblock the release. Lerna v6 is incompatible with Prettier v3, requiring an upgrade. The Husky hook & pretty-quick are no longer functional with the recent Prettier change so they have been removed to avoid pulling in the older version of Prettier and breaking Lerna.
Issue #, if available
Description of how you validated changes
Tested
publish:releasein Verdaccio, worked without error:Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.