chore: Upgrade to Lerna v7 #12605
Merged
chore: Upgrade to Lerna v7 #12605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
commented
Nov 21, 2023
| @@ -1,29 +1,5 @@ | |||
| { | |||
| "npmClient": "yarn", | |||
| "useWorkspaces": true, | |||
| "packages": [ | |||
There was a problem hiding this comment.
Lerna v7 will defer entirely to the Yarn workspace configuration.
| @@ -84,6 +79,7 @@ | |||
| "@babel/core": "7.17.2", | |||
| "@babel/preset-env": "^7.0.0", | |||
| "@babel/preset-react": "^7.0.0", | |||
| "@lerna/legacy-package-management": "^7.4.2", | |||
There was a problem hiding this comment.
Required to support the bootstrap command as described here: https://lerna.js.org/docs/legacy-package-management#temporarily-polyfilling-legacy-package-management-commands
Long term, we'll want to migrate to Yarn 2 or 3 and entirely use the Yarn workspace feature.
ashwinkumar6
approved these changes
Nov 22, 2023
4 tasks
icazevedo
pushed a commit
to vtex/faststore
that referenced
this pull request
Dec 7, 2023
## What's the purpose of this pull request? Fix CD ## How it works? Updates lerna so it no longer depends on prettier@2. ## How to test it? Merge this 😆 (rly tho) ## References aws-amplify/amplify-js#12605
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR upgrades to Lerna v7 and removes Husky & the associated dependencies. This upgrade is required to support the use of Prettier v3, which Lerna v6 does not support.
Issue #, if available
Description of how you validated changes
publish:verdaccio&publish:release:Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.