add "core" package to API package as a peerdep #12619
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The
core
package is consumed byapi
but is not declared as a dependency in theapi
's package.jsonhttps://github.com/aws-amplify/amplify-js/blob/main/packages/api/src/API.ts#L5
https://github.com/aws-amplify/amplify-js/blob/main/packages/api/package.json#L70-L74
This change modifies the dependencies of the API package to mimic its dependencies https://github.com/aws-amplify/amplify-js/blob/main/packages/api-rest/package.json#L86-L90
@aws-amplify/api
's dependencies:api-rest
andapi-graphql
@aws-amplify/core
as a devDependency to@aws-amplify/api
@aws-amplify/core
as a peerDependency to@aws-amplify/api
Issue #, if available
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.