-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(data): fix library configuration options headers for subscriptions (#12590) #12659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-mcafee
changed the title
fix(data): fix singleton subscription headers
fix(data): fix library configuration options headers for subscriptions; update core headers type
Dec 1, 2023
david-mcafee
changed the title
fix(data): fix library configuration options headers for subscriptions; update core headers type
fix(data): fix library configuration options headers for subscriptions
Dec 1, 2023
david-mcafee
changed the title
fix(data): fix library configuration options headers for subscriptions
fix(data): fix library configuration options headers for subscriptions (#12590)
Dec 1, 2023
iartemiev
reviewed
Dec 1, 2023
stocaaro
approved these changes
Dec 1, 2023
iartemiev
approved these changes
Dec 1, 2023
elorzafe
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
thanks @david-mcafee 🎖️
kvramyasri7
approved these changes
Dec 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
thanks @david-mcafee 🎖️🥇🎖️
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Passes
headers
to the AWSAppSyncRealTimeProvider when callingAmplify.configure
. For example:headers
here was previouslygraphql_headers
in V5. These are separate from custom headers, and will always take precedence over custom headers (i.e. theAuthorization
token will never be overwritten).Issue #, if available
#12590
Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.