fix(logging): update public apis #12898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashwinkumar6
changed the title
cshfang
approved these changes
Jan 25, 2024
Comment on lines
7
to
8
| describe('Cloudwatch provider APIs: getCloudWatchProvider', () => { | ||
| it('should get cloudWatchProvider', () => { |
There was a problem hiding this comment.
Nit: Doesn't need to be addressed yet since these are more or less just placeholders at this time but I think the test descriptions are out of date
There was a problem hiding this comment.
ahh yes, will take note to update these test names
thanks
jimblanc
approved these changes
Jan 26, 2024
Samaritan1011001
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Public logging APIs
BEFORE
enabledisableflushLogscreateLoggerenabledisablegetProviderenabledisablegetProviderAFTER (with this PR)
enabledisableflushLogscreateLoggerconfigureflushLogscreateLoggerconfigurePS
cloudwatchobject will also be exposed at both category and cw provider level in another PRDescription of how you validated changes
verified apis are visible
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.