Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (Geo) Kebab case to Camel case config props #12921

Closed
wants to merge 21 commits into from
Closed

fix: (Geo) Kebab case to Camel case config props #12921

Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
c3e159e
fix: Kebab case to Camel case config props
nadetastic Jan 27, 2024
38164f8
fix: Typo on I18n comment
nadetastic Jan 30, 2024
2e8f146
address fix in tests
nadetastic Feb 1, 2024
edd34bc
Resolve build error
nadetastic Feb 1, 2024
099e9a3
Resolve build error
nadetastic Feb 1, 2024
1daab2a
Merge branch 'main' into fix/geo-location-services-config
nadetastic Feb 1, 2024
13e9cee
resolve PR failures
nadetastic Feb 1, 2024
0009a84
Merge branch 'fix/geo-location-services-config' of https://github.com…
nadetastic Feb 1, 2024
a7e7980
Merge branch 'main' into fix/geo-location-services-config
kvramyasri7 Feb 2, 2024
8e8f46e
update Geo tests
nadetastic Feb 16, 2024
11467af
Merge branch 'main' into fix/geo-location-services-config
nadetastic Feb 16, 2024
f50912b
Integ test check
nadetastic Mar 13, 2024
e3e8fcd
integ test
nadetastic Mar 13, 2024
971a645
integ test
nadetastic Mar 13, 2024
4f5f706
Merge branch 'main' into fix/geo-location-services-config
nadetastic Mar 25, 2024
f1b31f7
fix parseAWSExports duplicating "search_indices" and "searchIndicies"
nadetastic Mar 26, 2024
8771bcd
Merge branch 'main' into fix/geo-location-services-config
nadetastic Mar 26, 2024
eb12bd7
fix prettier error
ashika112 Apr 27, 2024
cb97136
Merge branch 'main' of github.com:ashika112/amplify-js into fix/geo-l…
ashika112 Apr 27, 2024
003f84d
fix bundle size test
ashika112 Apr 27, 2024
c023153
Merge branch 'main' of github.com:aws-amplify/amplify-js into fix/geo…
ashika112 Apr 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/I18n/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export class I18n {
* @static
* @method
* Add vocabularies for one language
* @param {String} langurage - Language of the dictionary
* @param {String} language - Language of the dictionary
* @param {Object} vocabularies - Object that has key-value as dictionary entry
*/
static putVocabulariesForLanguage(
Expand Down
8 changes: 4 additions & 4 deletions packages/geo/__tests__/Geo.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ describe('Geo', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
Text: testString,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down Expand Up @@ -368,7 +368,7 @@ describe('Geo', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
PlaceId: testPlaceId,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down Expand Up @@ -414,7 +414,7 @@ describe('Geo', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
Text: testString,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down Expand Up @@ -530,7 +530,7 @@ describe('Geo', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
Position: testCoordinates,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down
8 changes: 4 additions & 4 deletions packages/geo/__tests__/Providers/AmazonLocationServiceProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ describe('AmazonLocationServiceProvider', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
Text: testString,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down Expand Up @@ -367,7 +367,7 @@ describe('AmazonLocationServiceProvider', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
Text: testString,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down Expand Up @@ -527,7 +527,7 @@ describe('AmazonLocationServiceProvider', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
PlaceId: testPlaceId,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down Expand Up @@ -609,7 +609,7 @@ describe('AmazonLocationServiceProvider', () => {
const input = spyon.mock.calls[0][0].input;
expect(input).toEqual({
Position: testCoordinates,
IndexName: awsConfig.geo.amazon_location_service.search_indices.default,
IndexName: awsConfig.geo.amazon_location_service.searchIndices.default,
});
});

Expand Down
2 changes: 1 addition & 1 deletion packages/geo/__tests__/testData.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export const awsConfig = {
},
default: 'geoJsExampleMap1',
},
search_indices: {
searchIndices: {
nadetastic marked this conversation as resolved.
Show resolved Hide resolved
items: ['geoJSSearchExample'],
default: 'geoJSSearchExample',
},
Expand Down
9 changes: 4 additions & 5 deletions packages/geo/src/providers/location-service/AmazonLocationServiceProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ export class AmazonLocationServiceProvider implements GeoProvider {
*/
let locationServiceInput: SearchPlaceIndexForTextCommandInput = {
Text: text,
IndexName: this._config.search_indices.default,
IndexName: this._config.searchIndices.default,
};

/**
Expand Down Expand Up @@ -219,7 +219,7 @@ export class AmazonLocationServiceProvider implements GeoProvider {
*/
let locationServiceInput: SearchPlaceIndexForSuggestionsCommandInput = {
Text: text,
IndexName: this._config.search_indices.default,
IndexName: this._config.searchIndices.default,
};

/**
Expand Down Expand Up @@ -288,8 +288,7 @@ export class AmazonLocationServiceProvider implements GeoProvider {

const searchByPlaceIdInput: GetPlaceCommandInput = {
PlaceId: placeId,
IndexName:
options?.searchIndexName || this._config.search_indices.default,
IndexName: options?.searchIndexName || this._config.searchIndices.default,
};
const command = new GetPlaceCommand(searchByPlaceIdInput);

Expand Down Expand Up @@ -328,7 +327,7 @@ export class AmazonLocationServiceProvider implements GeoProvider {

const locationServiceInput: SearchPlaceIndexForPositionCommandInput = {
Position: coordinates,
IndexName: this._config.search_indices.default,
IndexName: this._config.searchIndices.default,
};

if (options) {
Expand Down
Loading