Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): not appending notification configs properly #12934

Conversation

Samaritan1011001
Copy link
Member

Description of changes

When parsing the aws exports file, Push Notification config will now be appended to the existing config rather than replacing it.

Issue #, if available

#12913

Description of how you validated changes

  • Linked the library and a sample app locally
  • Added InApp and Push to the sample app
  • Observe no error

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • [] Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Samaritan1011001 Samaritan1011001 requested review from a team as code owners February 1, 2024 01:04
Copy link
Member

@cshfang cshfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thank you!

@Samaritan1011001 Samaritan1011001 merged commit d7900dc into aws-amplify:main Feb 1, 2024
31 checks passed
@Samaritan1011001 Samaritan1011001 deleted the fix/notifications-config-core branch May 16, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants