Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api-graphql): wrong arguments for GET operation of a CPK model #12942

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Feb 2, 2024

Description of changes

Append ! to the generated arguments in the GraphQL document for a GET operation of a model that has custom primary key defined.

This PR should fix aws-amplify/amplify-category-api#2250

Issue #, if available

Description of how you validated changes

  • Unit testing
  • Manual integration test in a sample app

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner February 2, 2024 00:27
@HuiSF HuiSF force-pushed the hui/fix/api-graphql/arguments-cpk-model branch from 0c10f6c to 68ba367 Compare February 2, 2024 21:35
@HuiSF HuiSF merged commit d2367f7 into main Feb 2, 2024
30 checks passed
@HuiSF HuiSF deleted the hui/fix/api-graphql/arguments-cpk-model branch February 16, 2024 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Model Custom identifier graphql query error
3 participants