Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable eslint and remove tslint for react-native packages #13079

Merged
merged 5 commits into from
Mar 19, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Mar 4, 2024

Description of changes

See each commit for change details.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF requested a review from a team as a code owner March 4, 2024 22:42
jimblanc
jimblanc previously approved these changes Mar 5, 2024
Comment on lines +56 to +58
// 'packages/react-native',
// 'packages/rtn-push-notification',
// 'packages/rtn-web-browser',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three-fer!

@HuiSF HuiSF force-pushed the hui/chore/rtn-eslint branch from dd46c1b to a3ff658 Compare March 5, 2024 23:57
@HuiSF HuiSF force-pushed the hui/chore/rtn-eslint branch 2 times, most recently from 5f86a9b to 406412a Compare March 7, 2024 19:00
@HuiSF HuiSF requested a review from jimblanc March 7, 2024 19:00
@HuiSF HuiSF force-pushed the hui/chore/rtn-eslint branch 3 times, most recently from 5d91c7c to d68e73b Compare March 14, 2024 16:42
@HuiSF HuiSF force-pushed the hui/chore/rtn-eslint branch 2 times, most recently from 9da87f4 to 74fb48d Compare March 18, 2024 19:37
@HuiSF HuiSF force-pushed the hui/chore/rtn-eslint branch from 74fb48d to 69a0692 Compare March 19, 2024 21:49
@HuiSF HuiSF merged commit 0e0c496 into main Mar 19, 2024
30 checks passed
@HuiSF HuiSF deleted the hui/chore/rtn-eslint branch March 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants