chore(pubsub): enable eslint and remove tslint #13081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashika112
reviewed
Mar 5, 2024
| @@ -52,7 +53,7 @@ export enum ConnectionState { | |||
| ConnectedPendingKeepAlive = 'ConnectedPendingKeepAlive', | |||
| } | |||
|
|
|||
| export type PubSubContent = Record<string, unknown>; | |||
| export type PubSubContent = Record<string | symbol, unknown>; | |||
There was a problem hiding this comment.
curious: how is this coming up only now? 🤔
There was a problem hiding this comment.
In the api-graphql package (if I remembered correctly), it trying to assign an object that uses symbol as key to this type. Which causes incompatible key signature error, so expanding the key to union symbol here
ashika112
approved these changes
Mar 5, 2024
ashika112
reviewed
Mar 5, 2024
| }): void; | ||
| onConnectionLost(params: { errorCode: number }): void; | ||
| connect( | ||
| params: Record<string, string | number | boolean | (() => void)>, |
There was a problem hiding this comment.
Why prefer record over the current implementation?
There was a problem hiding this comment.
The original implementation is a Record with string as the key. Record is more readable and recommended I presume so it has been auto fixed.
jimblanc
approved these changes
Mar 5, 2024
HuiSF
force-pushed
the
hui/chore/pubsub/eslint
branch
from
678690c to
86323c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Change details see each commit of this PR.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.