feat(data): add configuration for API GraphQL Gen2 React Native E2E tests #13082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-mcafee
changed the title
david-mcafee
commented
Mar 5, 2024
| timeout_minutes: 120 | ||
| - test_name: 'integ_rn_ios_api_v6_rn_72_detox_cli' | ||
| working_directory: amplify-js-samples-staging/samples/react-native/api/v6/ApiGRAPHQL | ||
| # - test_name: 'integ_rn_ios_storage' |
There was a problem hiding this comment.
Updated for faster CI runs for testing. Will revert before merging PR.
david-mcafee
commented
Mar 5, 2024
| browser: ${{ toJSON(matrix.integ-config.browser) || '[""]' }} | ||
| timeout_minutes: ${{ matrix.integ-config.timeout_minutes || 35 }} | ||
| retry_count: ${{ matrix.integ-config.retry_count || 3 }} | ||
| # e2e-test-runner: |
There was a problem hiding this comment.
Will revert before merging PR.
david-mcafee
commented
Mar 5, 2024
| @@ -9,7 +9,7 @@ on: | |||
| push: | |||
| branches: | |||
| # Change this to your branch name where "example-preid" corresponds to the preid you want your changes released on | |||
| - feat/example-preid-branch/main | |||
| - gen2-rn-add-tests | |||
There was a problem hiding this comment.
Will revert before merging PR.
david-mcafee
commented
Mar 5, 2024
| # if your branch doesn't follow this pattern, you can override it here for your branch. | ||
| with: | ||
| preid: ${{ needs.parse-preid.outputs.preid }} | ||
| # preid-release: |
There was a problem hiding this comment.
Will revert before merging PR.
jimblanc
reviewed
Mar 5, 2024
iartemiev
approved these changes
Mar 6, 2024
jimblanc
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
feat(data): add configuration for API GraphQL Gen2 React Native E2E tests
Sample app + E2E tests PR
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.