Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): add selective dependency resolution for xml2js #13084

Merged
merged 6 commits into from
Mar 5, 2024

Conversation

david-mcafee
Copy link
Contributor

@david-mcafee david-mcafee commented Mar 5, 2024

Description of changes

Fixes https://github.com/aws-amplify/amplify-js/security/dependabot/63

Successful pipeline run against E2E tests

Note: one of the E2E tests is failing, but this is due to an expired API key and unrelated to this change.

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@david-mcafee david-mcafee self-assigned this Mar 5, 2024
@david-mcafee david-mcafee requested review from a team as code owners March 5, 2024 11:09
.github/workflows/push-preid-release.yml Outdated Show resolved Hide resolved
iartemiev
iartemiev previously approved these changes Mar 5, 2024
@david-mcafee david-mcafee requested a review from jimblanc March 5, 2024 19:12
stocaaro
stocaaro previously approved these changes Mar 5, 2024
Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update lockfile as well

@david-mcafee david-mcafee dismissed stale reviews from stocaaro and iartemiev via a9fc006 March 5, 2024 19:52
@david-mcafee david-mcafee requested a review from a team as a code owner March 5, 2024 19:52
@david-mcafee david-mcafee requested a review from jimblanc March 5, 2024 20:20
@david-mcafee david-mcafee merged commit 18bf983 into main Mar 5, 2024
31 checks passed
@david-mcafee david-mcafee deleted the dependabot-63-fix branch March 5, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants