chore: enable eslint for geo interactions and predictions packages #13092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/chore/geo-inter-pre-eslint
branch
from
ec34905 to
5663c57
Compare
ashika112
reviewed
Mar 9, 2024
packages/geo/src/providers/location-service/AmazonLocationServiceProvider.ts
Show resolved
Hide resolved
HuiSF
force-pushed
the
hui/chore/geo-inter-pre-eslint
branch
from
5663c57 to
5c7e2b5
Compare
ashika112
approved these changes
Mar 11, 2024
HuiSF
force-pushed
the
hui/chore/geo-inter-pre-eslint
branch
3 times, most recently
from
0df288d to
990d3c1
Compare
cshfang
approved these changes
Mar 18, 2024
| return; | ||
| } | ||
|
|
||
| // Push all successes to results | ||
| response.Successes?.forEach(success => { | ||
| const { GeofenceId, CreateTime, UpdateTime } = success; | ||
| const { GeofenceId: geofenceId, CreateTime, UpdateTime } = success; |
There was a problem hiding this comment.
For my curiosity, why was this needed for just GeofenceId?
There was a problem hiding this comment.
GeofenceId is declared in the upper scope already. shadow vars.
| return; | ||
| } | ||
|
|
||
| const badGeofenceIds = response.Errors.map( | ||
| const targetBadGeofenceIds = response.Errors.map( |
There was a problem hiding this comment.
Curious why this was needed too
| @@ -420,7 +430,7 @@ export class AmazonAIConvertPredictionsProvider { | |||
| region: string; | |||
| languageCode: string; | |||
| }): Promise<WebSocket> { | |||
| return new Promise(async (res, rej) => { | |||
| return new Promise((resolve, _reject) => { | |||
There was a problem hiding this comment.
Nit: Drop the reject altogether?
There was a problem hiding this comment.
There is no await in the promise executor function body. So the async is unnecessary.
HuiSF
force-pushed
the
hui/chore/geo-inter-pre-eslint
branch
2 times, most recently
from
d43cc16 to
295ad16
Compare
HuiSF
force-pushed
the
hui/chore/geo-inter-pre-eslint
branch
from
295ad16 to
5809612
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Details see each commit of this PR.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.