-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(auth): update tokenOrchestrator unit test exp token #13117
chore(auth): update tokenOrchestrator unit test exp token #13117
Conversation
375dc00
to
0e86c1c
Compare
8b736da
to
dc58311
Compare
dc58311
to
3f248f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Niceeee!!!!!! 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So much better. Thanks a ton 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for putting this together
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Description of changes
tokenOrchestrator
test is failing because of an expired tokentokenOrchestrator
file rather than importing from another util file authAPITestParamsdecodeJWT()
utilAlternative:
Spying on
decodeJWT()
in authAPITestParams to achieve the same is complex becauseChecklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.