feat(data): add DataStore query pagination unit tests #13129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-mcafee
commented
Mar 18, 2024
| @@ -65,6 +69,25 @@ describe('Indexed db storage test', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| afterEach(async () => { | |||
There was a problem hiding this comment.
I ran into a strange error when reproducing this issue. In the final test, where I create a single record with a page value greater than 0 (which should not return any records), I was received 10+ records that were not being returned by any of the tests. I attempted to clear / reset DataStore at a more fundamental level in this test, but decided to timebox the effort and add this step as a temporary cleanup solution so that results from previous tests did not bleed into the other tests.
svidgen
reviewed
Mar 18, 2024
david-mcafee
commented
Mar 18, 2024
| }); | ||
|
|
||
| // Assertion fails - record is returned: | ||
| expect(secondPage.length).toEqual(0); |
There was a problem hiding this comment.
This test currently fails - once we've found a fix, this should pass.
david-mcafee
commented
Mar 18, 2024
| }); | ||
|
|
||
| // Assertion fails - record is returned: | ||
| expect(thirdPage.length).toEqual(0); |
There was a problem hiding this comment.
This test currently fails - once we've found a fix, this should pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Adding unit tests that reproduce #12049. See comments for which tests are failing.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.