Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase bundle size #13138

Closed
wants to merge 1 commit into from

Conversation

ashwinkumar6
Copy link
Member

Description of changes

Increase bundle size

Checklist

  • PR description included
  • yarn test passes

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashwinkumar6 ashwinkumar6 requested a review from a team as a code owner March 18, 2024 14:34
@@ -467,7 +467,7 @@
"name": "[Storage] downloadData (S3)",
"path": "./dist/esm/storage/index.mjs",
"import": "{ downloadData }",
"limit": "14.00 kB"
"limit": "14.15 kB"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"limit": "14.15 kB"
"limit": "11.23 k..."

Copy link
Contributor

@jimblanc jimblanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still needed? Looks like bundle tests are passing on main

@ashwinkumar6
Copy link
Member Author

ashwinkumar6 commented Mar 20, 2024

Raised this PR when I was debugging sync gen2-storage with main issue
Yep, this isn't required anymore, closing

@ashwinkumar6 ashwinkumar6 deleted the increase-bundle branch March 20, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants