chore: Small cleanup to internal core utils #13140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-mcafee
previously approved these changes
Mar 18, 2024
ashika112
reviewed
Mar 18, 2024
| type StrictUnionHelper<T, TAll> = T extends any | ||
| ? T & Partial<Record<Exclude<UnionKeys<TAll>, keyof T>, never>> | ||
| : never; | ||
|
|
There was a problem hiding this comment.
Nit: Should we add a comment to explain util function here?
israx
previously approved these changes
Mar 18, 2024
| @@ -4,3 +4,4 @@ | |||
| export * from './core'; | |||
| export * from './errors'; | |||
| export * from './storage'; | |||
| export * from './utils'; | |||
There was a problem hiding this comment.
nit question,
Should these be updated to named exports later on to keep it uniform across all categories
There was a problem hiding this comment.
I'm not opposed to it but we do this in various other places as well - including other packages - so I'm not sure this is the right PR to do this in
cshfang
dismissed stale reviews from ashwinkumar6, israx, and david-mcafee
via
9e69d97
israx
approved these changes
Mar 18, 2024
ashwinkumar6
approved these changes
Mar 18, 2024
ashika112
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR introduces some minor cleanup to improve consistency and structural semantics in
core:WordArrayas module member so it can be re-exported directly bylibraryUtils.tsStrictUnionto core root level types since it is not actually coupled to Auth (and will be used by Storage in future PRs)Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.