Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor setConflictHandler to avoid directly exporting let #13143

Merged
merged 4 commits into from
Mar 19, 2024

Conversation

cshfang
Copy link
Member

@cshfang cshfang commented Mar 18, 2024

Description of changes

This PR refactors the InAppMessaging setConflictHandler API module so it no longer contains a mutable export.

Description of how you validated changes

$ yarn clean && yarn && yarn build && yarn test

Checklist

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cshfang cshfang requested a review from a team as a code owner March 18, 2024 21:29
@cshfang cshfang requested a review from HuiSF March 18, 2024 21:30
Copy link
Contributor

@erinleigh90 erinleigh90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks

@cshfang cshfang merged commit 22d042d into aws-amplify:main Mar 19, 2024
30 checks passed
@cshfang cshfang deleted the chore/refactor-conflict-handler branch March 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants