fix(auth): add inflightPromise in token orchestrator #13158
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
reviewed
Mar 21, 2024
| } | ||
|
|
||
| return new Promise<void>((resolve, _reject) => { | ||
| addInflightPromise(resolve); |
There was a problem hiding this comment.
Should we remove the addInflightPromise() call from attempCompleteOAuthFlow then?
There was a problem hiding this comment.
cognitoUserPoolsTokenProvider.setWaitForInflightOAuth should be removed as well as its single use case is being replace by this. 👍
jimblanc
reviewed
Mar 21, 2024
| @@ -23,13 +23,23 @@ import { | |||
| DeviceMetadata, | |||
| TokenRefresher, | |||
| } from './types'; | |||
| import { oAuthStore } from '../utils/oauth'; | |||
| import { addInflightPromise } from '../utils/oauth/inflightPromise'; | |||
|
|
|||
| export class TokenOrchestrator implements AuthTokenOrchestrator { | |||
| private authConfig?: AuthConfig; | |||
| tokenStore?: AuthTokenStore; | |||
| tokenRefresher?: TokenRefresher; | |||
| waitForInflightOAuth: () => Promise<void> = async () => { | |||
| // no-op | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The main issue is due to a race condition between
attemptCompleteOAuthFlowandTokenOrchestrator.getTokensIdeally when there is an inflight OAuth flow,
attemptCompleteOAuthFlowshould always be called first to register any upcoming async calls coming fromTokenOrchestrator.getTokens. This behavior is consistent in React but the affected frameworks are bundled different.The fix at the moment is to check if
OAuthis inflight directly from the TokenOrchestrator and add an inflight promise if so.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.