fix(api-graphql): update error handling #13177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
force-pushed
the
hui/chore/api-graphql/error-handling
branch
from
e734eb0 to
46d2101
Compare
AllanZhengYP
previously approved these changes
Mar 26, 2024
HuiSF
force-pushed
the
hui/chore/api-graphql/error-handling
branch
from
46d2101 to
c6f26fa
Compare
HuiSF
commented
Mar 26, 2024
| @@ -2,7 +2,6 @@ | |||
| "extends": "../../tsconfig.json", | |||
| "compilerOptions": { | |||
| "strictNullChecks": true, | |||
| "baseUrl": ".", | |||
There was a problem hiding this comment.
This was add along with line 7-8 to resolve the type issues in the unit test suite. This baseUrl was actually not needed, and it caused an issue when IDE auto import symbols, it uses src/... path instead of relative paths.
HuiSF
commented
Mar 26, 2024
| await amplify.Auth.fetchAuthSession() | ||
| ).tokens?.accessToken.toString(); | ||
|
|
||
| if (!token) { | ||
| throw new Error(GraphQLAuthError.NO_FEDERATED_JWT); |
There was a problem hiding this comment.
This specific error was being swallowed by the catch clause. Rearranged the flow here to ensure both errors in this block to be able to surface.
HuiSF
commented
Mar 26, 2024
| @@ -335,7 +335,7 @@ | |||
| "name": "[API] generateClient (AppSync)", | |||
| "path": "./dist/esm/api/index.mjs", | |||
| "import": "{ generateClient }", | |||
| "limit": "38.00 kB" | |||
| "limit": "38.5 kB" | |||
There was a problem hiding this comment.
Mostly from the new messaging strings.
svidgen
approved these changes
Mar 27, 2024
AllanZhengYP
approved these changes
Mar 27, 2024
- Use GraphApiError to create errors to be thrown
* error message field remained the same as before
* added recoverySuggestion field for each error case
- Created createGraphQLResultWithError utility for rewrapping error into GraphQLResult format
HuiSF
force-pushed
the
hui/chore/api-graphql/error-handling
branch
from
c6f26fa to
7087449
Compare
ashika112
approved these changes
Mar 27, 2024
Samaritan1011001
pushed a commit
that referenced
this pull request
Apr 1, 2024
chore(api-graphql): improve error handling
- Use GraphApiError to create errors to be thrown
* error message field remained the same as before
* added recoverySuggestion field for each error case
- Created createGraphQLResultWithError utility for rewrapping error into GraphQLResult format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
See the commit message.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.