release(required): api-graphql - default selection set regression #13188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue #, if available
When generating the default selection set for a model, we were attempting to inject the
groupsField
of a static group auth rule e.g.a.allow.specificGroup('Admin')
. Only dynamic group model introspection auth attributes contain agroupsField
value, so we were inadvertently adding an explicitundefined
to the default selection set, which was causing unexpected behavior.This PR adds an additional check to make sure we're only adding the
groupsField
value when it's defined.Description of how you validated changes
Checklist
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.