-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/geo location services config #13303
Merged
ashika112
merged 26 commits into
aws-amplify:main
from
ashwinkumar6:fix/geo-location-services-config
Apr 28, 2024
Merged
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
c3e159e
fix: Kebab case to Camel case config props
nadetastic 38164f8
fix: Typo on I18n comment
nadetastic 2e8f146
address fix in tests
nadetastic edd34bc
Resolve build error
nadetastic 099e9a3
Resolve build error
nadetastic 1daab2a
Merge branch 'main' into fix/geo-location-services-config
nadetastic 13e9cee
resolve PR failures
nadetastic 0009a84
Merge branch 'fix/geo-location-services-config' of https://github.com…
nadetastic a7e7980
Merge branch 'main' into fix/geo-location-services-config
kvramyasri7 8e8f46e
update Geo tests
nadetastic 11467af
Merge branch 'main' into fix/geo-location-services-config
nadetastic f50912b
Integ test check
nadetastic e3e8fcd
integ test
nadetastic 971a645
integ test
nadetastic 4f5f706
Merge branch 'main' into fix/geo-location-services-config
nadetastic f1b31f7
fix parseAWSExports duplicating "search_indices" and "searchIndicies"
nadetastic 8771bcd
Merge branch 'main' into fix/geo-location-services-config
nadetastic eb12bd7
fix prettier error
ashika112 cb97136
Merge branch 'main' of github.com:ashika112/amplify-js into fix/geo-l…
ashika112 003f84d
fix bundle size test
ashika112 c023153
Merge branch 'main' of github.com:aws-amplify/amplify-js into fix/geo…
ashika112 438f25c
fix: update parseAWSExports
27fb817
cleanup
8719a92
update bundle size
31af65d
cleanup
82690c8
chore: cleanup
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -151,7 +151,7 @@ export class AmazonLocationServiceProvider implements GeoProvider { | |
*/ | ||
let locationServiceInput: SearchPlaceIndexForTextCommandInput = { | ||
Text: text, | ||
IndexName: this._config.search_indices.default, | ||
IndexName: this._config.searchIndices.default, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. GG : ) |
||
}; | ||
|
||
/** | ||
|
@@ -217,7 +217,7 @@ export class AmazonLocationServiceProvider implements GeoProvider { | |
*/ | ||
let locationServiceInput: SearchPlaceIndexForSuggestionsCommandInput = { | ||
Text: text, | ||
IndexName: this._config.search_indices.default, | ||
IndexName: this._config.searchIndices.default, | ||
}; | ||
|
||
/** | ||
|
@@ -286,8 +286,7 @@ export class AmazonLocationServiceProvider implements GeoProvider { | |
|
||
const searchByPlaceIdInput: GetPlaceCommandInput = { | ||
PlaceId: placeId, | ||
IndexName: | ||
options?.searchIndexName || this._config.search_indices.default, | ||
IndexName: options?.searchIndexName || this._config.searchIndices.default, | ||
}; | ||
const command = new GetPlaceCommand(searchByPlaceIdInput); | ||
|
||
|
@@ -325,7 +324,7 @@ export class AmazonLocationServiceProvider implements GeoProvider { | |
|
||
const locationServiceInput: SearchPlaceIndexForPositionCommandInput = { | ||
Position: coordinates, | ||
IndexName: this._config.search_indices.default, | ||
IndexName: this._config.searchIndices.default, | ||
}; | ||
|
||
if (options) { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfectoooo