fix(core): assign the correct keys for Apple and Amazon providers #13369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashika112
reviewed
May 13, 2024
| @@ -22,7 +22,7 @@ | |||
| "responseType": "token" | |||
| }, | |||
| "aws_cognito_verification_mechanisms": ["EMAIL"], | |||
| "aws_cognito_social_providers": ["FACEBOOK", "APPLE", "GOOGLE"], | |||
| "aws_cognito_social_providers": ["FACEBOOK", "APPLE", "GOOGLE", "AMAZON"], | |||
There was a problem hiding this comment.
wouldnt this be LOGIN_WITH_AMAZON for gen1 cases?
| @@ -7,7 +7,7 @@ | |||
| "user_pool_client_id": "mock-cup-client-id", | |||
| "identity_pool_id": "mock-idp-id", | |||
| "oauth": { | |||
| "identity_providers": ["FACEBOOK", "SIGN_IN_WITH_APPLE", "GOOGLE"], | |||
| "identity_providers": ["FACEBOOK", "APPLE", "GOOGLE", "AMAZON"], | |||
There was a problem hiding this comment.
How are we guaranteeing this mock has the correct output from defineAuth?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Currently there is a key miss match present in the Amazon and Apple social providers generated by
amplifyOutputs. This PR matches the returned keys in theparseAmplifyOutputshelper.Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.