Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): validate if access and id tokens are valid cognito tokens #13385
feat(core): validate if access and id tokens are valid cognito tokens #13385
Changes from 10 commits
8bad71e
6c053e0
f007450
703394f
e741faa
d149005
7970a41
2b300b4
afb3ba2
dffa3cb
27f25d7
008eb27
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
getItem
method implies that it will get something but the return type is a boolean. We could either return the actualitem
/token
and returnnull
if it is invalid. The other option is to change the method name to something more deterministic that implies the validation of the token.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point 🤔,
This function returns a validationMap where the key is name of the function in KeyValueStorage that we want to add validation for (
getItem
in this case) and the value is the validation function that returns a bool if the validation was successful or nowWe could maybe improve the function name to clarity that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we can require these two fields from
createTokenValidator
's consumer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we make userPoolId and clientId required fields in this function, we would need make sure these are passed by it's consumer
createRunWithAmplifyServerContext
.It's a bit tricky because if we add assertions in
createRunWithAmplifyServerContext
, we won't be able to get other keys from Storage if userPoolId or clientId are missing.