fix(auth): Added missing UserContextData to Cognito User Pool operation SignUp #13477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimblanc
reviewed
Jun 7, 2024
israx
previously approved these changes
Jun 7, 2024
jimblanc
suggested changes
Jun 7, 2024
cshfang
reviewed
Jun 7, 2024
Comment on lines
77
to
81
| const UserContextData = getUserContextData({ | ||
| username, | ||
| userPoolId, | ||
| userPoolClientId, | ||
| }); |
There was a problem hiding this comment.
Nit: Can we move this directly into line 96? I think getUserContextData is expressive enough to convey the context there when used directly. Also prefer not to have the PascalCased variable as it easily gets confused with types/interfaces/classes
jimblanc
previously approved these changes
Jun 17, 2024
armandsyah134
requested review from
ukhan-amazon,
haverchuck and
HuiSF
as code owners
haverchuck
previously approved these changes
Jun 17, 2024
…extData to inside the parameter list
…ithub.com/armandsyah134/amplify-js into auth/fix-adding-usercontextdata-to-signup
…ata-to-signup Auth/fix adding usercontextdata to signup
armandsyah134
dismissed stale reviews from israx, haverchuck, and jimblanc
via
3839009
jimblanc
previously approved these changes
Jun 18, 2024
…ata-to-signup Fix unit test for SignUp
israx
approved these changes
Jun 18, 2024
jimblanc
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
UserContextDatainSignUpcall to Cognito User Pools (CUP)UserContextDatais an important property for Sign Up calls, and should be added to theSignUpoperationUserContextData(e.g. ConfirmSignUp)UserContextDatais already in your API contractIssue #, if available
N/a (will make an issue for this if required
Description of how you validated changes
UserContextDatapresent in SignUp callChecklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.