[Chore]Update aws-sdk dependencies to latest possible #13665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashika112
commented
Jul 30, 2024
ashika112
commented
Jul 30, 2024
3 tasks
ashika112
commented
Aug 2, 2024
| @@ -164,7 +168,7 @@ export class AmazonAIConvertPredictionsProvider { | |||
| const synthesizeSpeechCommand = new SynthesizeSpeechCommand({ | |||
| OutputFormat: 'mp3', | |||
| Text: input.textToSpeech?.source?.text, | |||
| VoiceId: voiceId, | |||
| VoiceId: voiceId as SynthesizeSpeechInput['VoiceId'], | |||
There was a problem hiding this comment.
All these casting is required since SDK updated the types to be stricter than before and this avoids breaking change and anything outside of this will throw an error from API itself
stocaaro
previously approved these changes
Aug 2, 2024
| @@ -195,79 +195,6 @@ describe('server generateClient', () => { | |||
| ); | |||
| }); | |||
|
|
|||
| test('can list with sort direction (ascending)', async () => { | |||
There was a problem hiding this comment.
Note
Confirm that this test is not relevant without using compound keys for sorting, which should be tested by data-schema directly instead of indirectly through this abstraction.
| @@ -296,7 +223,9 @@ describe('server generateClient', () => { | |||
| config: config, | |||
| }); | |||
|
|
|||
| const mockContextSpec = {}; | |||
| const mockContextSpec = { | |||
There was a problem hiding this comment.
Note
Type changed from any to specific type, which breaks this test, but the type would be required for a customers app to work.
stocaaro
approved these changes
Aug 2, 2024
|
Performing yarn why and yarn audit post this fix,
|
Open
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update aws-sdk dependencies to latest (3.621.0) possible
Issue #, if available
Fixes: #13670
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.