Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner #13788

Open
wants to merge 1 commit into
base: feat/server-auth/main
Choose a base branch
from

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 6, 2024

Description of changes

Add runtimeOptions to the createServerRunner function. e.g.:

createServerRunner({
  config,
  runtimeOptions: {
    cookies: {
      domain: '.example.com',
      sameSite: 'strict',
    }
  }
})

Issue #, if available

Description of how you validated changes

  • unit tests
  • manual testing with a sample app

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/apply-cookie-attrs branch from b47d2f2 to 6cbdad1 Compare September 11, 2024 20:56
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/apply-cookie-attrs branch from 6cbdad1 to af39e86 Compare October 1, 2024 23:01
@HuiSF HuiSF changed the title feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner Oct 1, 2024
const overrideCookieAttributes = {
...setCookieOptions,
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of spreading here first? Wouldn't the spread operation below avoid any issues with accidental top level referential assignment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants