Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): Enable resumable SignIn (#13855) #14074

Merged
merged 15 commits into from
Dec 18, 2024
Merged

feat(auth): Enable resumable SignIn (#13855) #14074

merged 15 commits into from
Dec 18, 2024

Conversation

joon-won
Copy link
Member

@joon-won joon-won commented Dec 12, 2024 •
edited
Loading

Description of changes

  • Enable v6 users to have an option to continue SignIn process after a full browser reload by storing, then utilizing session in session storage

Issue #, if available

Description of how you validated changes

  • Unit Tests added
  • E2E for Custom Auth flow and SMS MFA added
  • Manual testing

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions GitHub Actions
Copy link

⚠️ This PR includes changes to the "aws-amplify" package.json file, which can have library-wide implications.

Please ensure that this PR:

  • Does not manually change "@aws-amplify/*" dependency versions, which may misalign core dependencies across the library
  • Remove any export paths without a major version bump

A repository administrator is required to review this change.

@HuiSF HuiSF changed the title Reintroduce "feat(auth): Enable resumable SignIn (#13855)" feat(auth): Enable resumable SignIn (#13855) Dec 12, 2024
@joon-won joon-won requested a review from HuiSF December 12, 2024 18:58
@joon-won joon-won requested a review from jjarvisp December 13, 2024 01:04
jjarvisp
jjarvisp previously approved these changes Dec 18, 2024
View reviewed changes
@joon-won joon-won requested a review from jjarvisp December 18, 2024 02:33
cshfang
cshfang reviewed Dec 18, 2024
View reviewed changes
packages/core/__tests__/storage/SyncSessionStorage.test.ts Outdated Show resolved Hide resolved
packages/core/__tests__/storage/SyncSessionStorage.test.ts Show resolved Hide resolved
packages/core/__tests__/storage/SyncSessionStorage.test.ts Outdated Show resolved Hide resolved
packages/auth/src/providers/cognito/apis/confirmSignIn.ts Outdated Show resolved Hide resolved
packages/auth/src/client/utils/store/signInStore.ts Outdated Show resolved Hide resolved
packages/auth/src/client/utils/store/signInStore.ts Outdated Show resolved Hide resolved
packages/auth/src/client/utils/store/signInStore.ts Outdated Show resolved Hide resolved
packages/auth/src/client/utils/store/signInStore.ts Outdated Show resolved Hide resolved
packages/auth/src/client/flows/userAuth/handleWebAuthnSignInResult.ts Show resolved Hide resolved
cshfang
cshfang previously approved these changes Dec 18, 2024
View reviewed changes
jjarvisp
jjarvisp previously approved these changes Dec 18, 2024
View reviewed changes
packages/auth/src/providers/cognito/apis/signInWithUserAuth.ts Outdated Show resolved Hide resolved
packages/auth/src/client/utils/store/signInStore.ts
| { type: 'SET_SIGN_IN_SESSION'; value?: string }
| { type: 'RESET_STATE' };

// Minutes until stored session invalidates
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: brief explanation of the reasoning behind this expiration might be helpful for folks without context.

@joon-won joon-won dismissed stale reviews from jjarvisp and cshfang via 67c22aa December 18, 2024 23:35
@joon-won joon-won requested review from cshfang and jjarvisp December 18, 2024 23:36
@joon-won joon-won merged commit fe315be into main Dec 18, 2024
30 checks passed
@joon-won joon-won deleted the joonwonc/auth-resumablesignin-revert branch December 18, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjarvisp jjarvisp jjarvisp approved these changes

@HuiSF HuiSF HuiSF approved these changes

@sktimalsina sktimalsina Awaiting requested review from sktimalsina sktimalsina is a code owner

@pranavosu pranavosu Awaiting requested review from pranavosu pranavosu is a code owner

@cshfang cshfang Awaiting requested review from cshfang cshfang is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joon-won @cshfang @HuiSF @jjarvisp