fix(core): generateRandomString uses Math.random() #14132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
requested review from
sktimalsina,
cshfang,
pranavosu and
a team
as code owners
HuiSF
changed the title
ashwinkumar6
approved these changes
Jan 10, 2025
cshfang
reviewed
Jan 10, 2025
Comment on lines
+28
to
+30
| const length = 10; | ||
| const result = generateRandomString(length); | ||
| expect(result).toHaveLength(length); |
There was a problem hiding this comment.
Nit: I think it's probably ok to just be concise here
Suggested change
| const length = 10; | |
| const result = generateRandomString(length); | |
| expect(result).toHaveLength(length); | |
| expect(generateRandomString(length)).toHaveLength(10); |
| expect(crypto.getRandomValues).toHaveBeenCalledWith(expect.any(Uint8Array)); | ||
| }); | ||
|
|
||
| it('generates different strings on subsequent calls', () => { |
There was a problem hiding this comment.
Is this a meaningful assertion given the mocked getRandomValues?
cshfang
reviewed
Jan 10, 2025
| } | ||
| const array = new Uint8Array(bufferView.buffer); | ||
| for (let i = 0; i < array.byteLength; i++) { | ||
| array[i] = Math.floor(Math.random() * 256); |
There was a problem hiding this comment.
Maybe instead of trying to replicate randomness, we should trust that getRandomValues would indeed give us random values and we mock here with something static that we can assert our actual logic (what we end up doing with the random values) is correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Update the existing
generateRandomString()implementation to usecrypto.getRandomValues().Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.