Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authenticator): Add default error string for LimitExceededException #182

Merged
merged 3 commits into from
Sep 6, 2024

Conversation

mattcreaser
Copy link
Member

Issue #, if available: #180

Description of changes:

This PR adds a new string: amplify_ui_authenticator_error_limit_exceeded

Add default handling for the LimitExceededException. This can occur if a user e.g. tries to enter an incorrect confirmation code too many times.

How did you test these changes?

  • Unit test
  • Entered confirmation code too many times and verified expected message.

Screenshot_20240821_112548

Documentation update required?

  • No
  • Yes (Please include a PR link for the documentation update)

General Checklist

  • Added Unit Tests
  • Added Integration Tests
  • Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)
  • Ensure commit message has the appropriate scope (e.g fix(liveness): message, fix(authenticator): message, fix(all): message)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mattcreaser mattcreaser requested review from a team as code owners August 21, 2024 14:29
@mattcreaser mattcreaser added the L10N Updates Marks a PR as containing Localization updates, which should be called out in the changelog label Aug 21, 2024
@mattcreaser mattcreaser changed the title feat(Authenticator): Add default error string for LimitExceededException feat(authenticator): Add default error string for LimitExceededException Aug 21, 2024
harsh62
harsh62 previously approved these changes Aug 21, 2024
@mattcreaser mattcreaser merged commit 3222c3c into main Sep 6, 2024
1 check passed
@mattcreaser mattcreaser deleted the mattcreaser/authenticator-limit-exceeded-error branch September 6, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L10N Updates Marks a PR as containing Localization updates, which should be called out in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants